<html>
<head><meta charset="utf-8"><title>backport https://github.com/rust-lang/rust/pull/75494 · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20https.3A.2F.2Fgithub.2Ecom.2Frust-lang.2Frust.2Fpull.2F75494.html">backport https://github.com/rust-lang/rust/pull/75494</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="207563326"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20https%3A//github.com/rust-lang/rust/pull/75494/near/207563326" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20https.3A.2F.2Fgithub.2Ecom.2Frust-lang.2Frust.2Fpull.2F75494.html#207563326">(Aug 20 2020 at 19:21)</a>:</h4>
<p><span class="user-mention" data-user-id="116118">@Matthew Jasper</span> <span class="user-mention" data-user-id="116009">@nikomatsakis</span> <span class="user-mention" data-user-id="116083">@pnkfelix</span> So we spent a while discussing this today, and it turns out it does not backport cleanly.</p>



<a name="207563348"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20https%3A//github.com/rust-lang/rust/pull/75494/near/207563348" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20https.3A.2F.2Fgithub.2Ecom.2Frust-lang.2Frust.2Fpull.2F75494.html#207563348">(Aug 20 2020 at 19:21)</a>:</h4>
<p>(and the diff looks pretty bad)</p>



<a name="207563362"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20https%3A//github.com/rust-lang/rust/pull/75494/near/207563362" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20https.3A.2F.2Fgithub.2Ecom.2Frust-lang.2Frust.2Fpull.2F75494.html#207563362">(Aug 20 2020 at 19:22)</a>:</h4>
<p>but I'm unfamiliar with this area, so maybe there's an easy patch on beta</p>



<a name="207563973"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20https%3A//github.com/rust-lang/rust/pull/75494/near/207563973" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20https.3A.2F.2Fgithub.2Ecom.2Frust-lang.2Frust.2Fpull.2F75494.html#207563973">(Aug 20 2020 at 19:27)</a>:</h4>
<p>was beta before the <code>ForAll</code> split?</p>



<a name="207564006"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20https%3A//github.com/rust-lang/rust/pull/75494/near/207564006" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20https.3A.2F.2Fgithub.2Ecom.2Frust-lang.2Frust.2Fpull.2F75494.html#207564006">(Aug 20 2020 at 19:27)</a>:</h4>
<p>maybe? not sure</p>



<a name="207564206"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20https%3A//github.com/rust-lang/rust/pull/75494/near/207564206" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20https.3A.2F.2Fgithub.2Ecom.2Frust-lang.2Frust.2Fpull.2F75494.html#207564206">(Aug 20 2020 at 19:29)</a>:</h4>
<p>doesn't seem like that's the problem here <span aria-label="thinking" class="emoji emoji-1f914" role="img" title="thinking">:thinking:</span></p>



<a name="207564926"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20https%3A//github.com/rust-lang/rust/pull/75494/near/207564926" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20https.3A.2F.2Fgithub.2Ecom.2Frust-lang.2Frust.2Fpull.2F75494.html#207564926">(Aug 20 2020 at 19:34)</a>:</h4>
<p>if someone wants to rebase and provide a diff that's fine by me or you can just push to the beta backport branch </p>
<p><code>git push git@github.com:Mark-Simulacrum/rust.git HEAD:beta-next</code> should work after you checkout my beta-next branch and add a commit atop</p>



<a name="207565767"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20https%3A//github.com/rust-lang/rust/pull/75494/near/207565767" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20https.3A.2F.2Fgithub.2Ecom.2Frust-lang.2Frust.2Fpull.2F75494.html#207565767">(Aug 20 2020 at 19:43)</a>:</h4>
<p>I can try to take a look but maybe it makes our decision for us ;)</p>



<a name="207566834"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20https%3A//github.com/rust-lang/rust/pull/75494/near/207566834" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20https.3A.2F.2Fgithub.2Ecom.2Frust-lang.2Frust.2Fpull.2F75494.html#207566834">(Aug 20 2020 at 19:52)</a>:</h4>
<p>yeah :/</p>



<a name="207566881"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20https%3A//github.com/rust-lang/rust/pull/75494/near/207566881" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20https.3A.2F.2Fgithub.2Ecom.2Frust-lang.2Frust.2Fpull.2F75494.html#207566881">(Aug 20 2020 at 19:53)</a>:</h4>
<p>I'll r+ the beta backport PR tonight/tomorrow and can kick off a crater run once the PR merges</p>



<a name="207567076"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20https%3A//github.com/rust-lang/rust/pull/75494/near/207567076" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20https.3A.2F.2Fgithub.2Ecom.2Frust-lang.2Frust.2Fpull.2F75494.html#207567076">(Aug 20 2020 at 19:54)</a>:</h4>
<p>but it does seem like we might not want to backport given all this</p>



<a name="207576908"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20https%3A//github.com/rust-lang/rust/pull/75494/near/207576908" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthew Jasper <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20https.3A.2F.2Fgithub.2Ecom.2Frust-lang.2Frust.2Fpull.2F75494.html#207576908">(Aug 20 2020 at 21:30)</a>:</h4>
<p>I've pushed a backport to <code>beta-next</code></p>



<a name="207577330"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20https%3A//github.com/rust-lang/rust/pull/75494/near/207577330" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20https.3A.2F.2Fgithub.2Ecom.2Frust-lang.2Frust.2Fpull.2F75494.html#207577330">(Aug 20 2020 at 21:35)</a>:</h4>
<p><span class="user-mention" data-user-id="116118">@Matthew Jasper</span> do you want someone to sign-off on that? (e.g., <span class="user-mention" data-user-id="116009">@nikomatsakis</span>)</p>



<a name="207577344"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20https%3A//github.com/rust-lang/rust/pull/75494/near/207577344" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20https.3A.2F.2Fgithub.2Ecom.2Frust-lang.2Frust.2Fpull.2F75494.html#207577344">(Aug 20 2020 at 21:35)</a>:</h4>
<p>regardless I'll r+, we can revert if necessary but I'd rather get it testing...</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>